Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logger for Node sub classes do not get properly namespaced #896

Closed
sphuber opened this issue Nov 7, 2017 · 1 comment
Closed

Logger for Node sub classes do not get properly namespaced #896

sphuber opened this issue Nov 7, 2017 · 1 comment
Assignees
@sphuber @giovannipizzi
Labels
type/bug

Comments

@sphuber
Copy link
Contributor

sphuber commented Nov 7, 2017

The __metaclass__ of the AbstractNode class does some magic to properly set the logger that is configured for AiiDA for all the sub classes, however it does not properly prepend it with aiida. This means that for sub classes that live outside of the aiida module, there module path will not match the aiida logger and the configured handlers and adapters will not be applied. As a result, for example, in JobCalculations that live in separate plugins, the DbLogHandler will not work as expected.
@sphuber
Copy link
Contributor Author

sphuber commented Nov 8, 2017

Fixed in PR #897

@sphuber sphuber closed this as completed Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sphuber sphuber

@giovannipizzi giovannipizzi

Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sphuber @giovannipizzi