Properly namespace the logger for sub classes of AbstractNode #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The __metaclass__ of the AbstractNode class does some magic to properly set the logger that is configured for AiiDA for all the sub classes, however it did not properly prepend it with the aiida namespace. This means that for sub classes that live outside of the aiida module, their module path will not match the aiida logger and the configured handlers and adapters will not be applied. As a result, for example, in JobCalculations that live in separate plugins, the DbLogHandler will not work as expected.
giovannipizzi
approved these changes
Nov 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metaclass of the AbstractNode class does some magic to
properly set the logger that is configured for AiiDA for all the
sub classes, however it did not properly prepend it with the aiida
namespace. This means that for sub classes that live outside of
the aiida module, their module path will not match the aiida logger
and the configured handlers and adapters will not be applied.
As a result, for example, in JobCalculations that live in separate
plugins, the DbLogHandler will not work as expected.