-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging develop into workflows #1113
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckend) that replaces the _dbnode member if a similar node already exists
…None for hash, which obviously should not be checked in the DB
…ditional extra (hash)
* Failing test for two ArrayData with unequal content * (Accidentally) passing test for two ArrayData of different size, with same str representation For the ArrayData, we need to take the actual array into account when creating the hash, not just the shape which is return in get_attrs()
Add more node hashing tests
Close files after reading them to create the hash.
The caching.defaults.use_cache parameter should be used by plugin developers to mark whether a specific .store() call CAN actually use caching. The user decides whether to use it in the end by setting the default to True / False.
…a logging mechanism for calculations that lose created data or called instance. Implemented a printout when this happens and storing to DbLog. To be reviewed for further improvements.
…ations that would lose created data or called instance will get this action written into the log. Additional warnings are printed, but it is still allowed to delete data without its creator or called workflows without their callers, since there are usecases
support the visualization of the structure with VESTA
that there are two band types (typically for spin)
Add two band types in JSON output
…ing_source_1026 Inline calculations storing source 1026
Verdi node delete 923
Marge Release v0.11.1 into develop
Hashing, caching and fast-forwarding
muhrin
approved these changes
Feb 13, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's too hard to check this properly so we'll rely on tests to flag up any problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will merge the big caching PR #652 from @greschd and other smaller recent commits to
develop
into theworkflows
branch