Fix import error and unnecessary backend check in verdi import #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The import functionality for files was still using the backend specific import functions, import_data_dj and import_data_sqla, while the one for URL's was using the generalized import_data. However, the latter was not imported. Hence an import error was raised. The solution is to import import_data function and update the section for files to use this one as well and not check the backend itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1139
The import functionality for files was still using the backend specific
import functions,
import_data_djandimport_data_sqla, while the one forURL's was using the generalized
import_data. However, the latter was notimported. Hence an import error was raised.
The solution is to import
import_datafunction and update the sectionfor files to use this one as well and not check the backend itself