Merge master after release of v0.11.4 into release_v0.12.0 #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was merged into develop with PR #1073 but needs to be back ported into release v0.11.4
The user is free to populate the context with Node instances, which means that if the WorkChain needs to be persisted that the nodes need to be serialized. Since the nodes are not necessarily stored upon calling save_instance_state, we also store them if they were not yet stored. We also use this opportunity to replace the ad hoc serialization in the pickle persister and use the new more complete serializer and deserializer.
This release of plumpy fixes an issue where the inputs of a process are recreated each time when loaded from a persisted state, meaning that inputs that were not explicitly specified but taken from the spec's default will be recreated. For default nodes in aiida-core this means that the nodes are duplicated multiple times
The verdi work list test that compared the output with and without the -a flag was failing sometimes, simply because the order was wrong but the exact string was compared. Sorting by code id will fix the order and this breaking test
This is an issue in plumpy that was also fixed there. The parsed inputs of a Process, which is returned by calling self.inputs, were being rebuilt from the raw inputs everytime the process was loaded from a persisted state. This meant that inputs that were not explicitly passed by the user and were populated with the defaults specified by the port, were being recreated upon reloading the instance. However, they should have been the ones that were created when the process was created the first time around. Therefore we persist the parsed inputs to the saved state and reload them instead of recreating them with `create_input_args`
Release v0.11.4
Also removed the duplicate entries from v0.12.0 change log that have now been backported and released in v0.11.4
ltalirz
approved these changes
Apr 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removed the duplicate entries from
v0.12.0change log thathave now been backported and released in
v0.11.4