-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix in custom schema (rest api) #1490
fix in custom schema (rest api) #1490
Conversation
@waychal First of all, thanks for the fix! Is the idea that the definition of the projections will move from the custom schema inside the |
Codecov Report
@@ Coverage Diff @@
## release_v0.12.1 #1490 +/- ##
===================================================
+ Coverage 54.42% 54.42% +<.01%
===================================================
Files 246 246
Lines 32454 32478 +24
===================================================
+ Hits 17663 17677 +14
- Misses 14791 14801 +10
Continue to review full report at Codecov.
|
@ltalirz part of the custom_schema will move to the ORM classes like help_text and display_name as they are more related to the node. is_display and ordering is required only in rest api.. so that part might go to the translator. I still need to finalise that. |
@ltalirz there is separate issue for moving custom_schema to orm classes and it requires time to solve that. Until then I guess its good to marge this pr to make the functionality working in current code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good!
Fixes #1390