Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor bug in delete_nodes utility due to typo #1564

Merged

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented May 22, 2018

Fixes #1563

Added a test that would have caught this bug. For this it was
necessary to set the verbosity to 2, because the bug was only
triggered in the branches of code for high verbosity. Additionally,
the tests created a simple graph of base Node instances, which
means that the logic involving Calculation nodes and CALL links
was not hit. The new test explicitly creates Calculation nodes with
CALL links to test this case

@sphuber sphuber requested review from lekah and giovannipizzi May 22, 2018 10:34
@codecov-io
Copy link

codecov-io commented May 22, 2018

Codecov Report

Merging #1564 into release_v0.12.1 will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release_v0.12.1    #1564      +/-   ##
===================================================
+ Coverage            54.63%   54.68%   +0.05%     
===================================================
  Files                  246      246              
  Lines                32419    32419              
===================================================
+ Hits                 17711    17729      +18     
+ Misses               14708    14690      -18
Impacted Files Coverage Δ
aiida/utils/delete_nodes.py 77.77% <100%> (+22.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87deb1e...2d4d86b. Read the comment docs.

Added a test that would have caught this bug. For this it was
necessary to set the verbosity to 2, because the bug was only
triggered in the branches of code for high verbosity. Additionally,
the tests created a simple graph of base Node instances, which
means that the logic involving Calculation nodes and CALL links
was not hit. The new test explicitly creates Calculation nodes with
CALL links to test this case
@sphuber sphuber deleted the fix_1563_verdi_node_delete branch May 22, 2018 15:45
@sphuber sphuber restored the fix_1563_verdi_node_delete branch May 22, 2018 15:52
@sphuber sphuber reopened this May 22, 2018
@sphuber sphuber merged commit 32724c9 into aiidateam:release_v0.12.1 May 22, 2018
@sphuber sphuber deleted the fix_1563_verdi_node_delete branch May 22, 2018 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants