Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace big export test data files with on the fly generated data #1645

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented Jun 13, 2018

Fixes #1632

Two export and import tests were relying on rather large export archives
to test the import functionality. However, since these archives were
included in the main aiida package, they would also be included in the
distribution, causing the package to become unnecessarily heavy. By
replacing these archives and tests with a variant that generates the
test data archive on the fly, the package size will be reduced by almost
have, while maintaining the same test coverage.

Two export and import tests were relying on rather large export archives
to test the import functionality. However, since these archives were
included in the main aiida package, they would also be included in the
distribution, causing the package to become unnecessarily heavy. By
replacing these archives and tests with a variant that generates the
test data archive on the fly, the package size will be reduced by almost
have, while maintaining the same test coverage.
@codecov-io
Copy link

Codecov Report

Merging #1645 into release_v0.12.1 will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release_v0.12.1    #1645      +/-   ##
===================================================
- Coverage            54.71%   54.66%   -0.05%     
===================================================
  Files                  246      246              
  Lines                32420    32420              
===================================================
- Hits                 17739    17723      -16     
- Misses               14681    14697      +16
Impacted Files Coverage Δ
aiida/common/pluginloader.py 65.64% <0%> (-10.69%) ⬇️
aiida/orm/importexport.py 79.05% <0%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9070e38...3d8116c. Read the comment docs.

Copy link
Member

@ltalirz ltalirz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while maintaining the same test coverage.

I'm seeing Coverage 54.71% 54.66% -0.05%

;-) just kidding - this is great, thanks a lot!

@sphuber
Copy link
Contributor Author

sphuber commented Jun 15, 2018

Since Codecov hasn't proven itself to be right most of the time, I am going to chalk this one up to Codecov :)

@szoupanos szoupanos merged commit 975d589 into aiidateam:release_v0.12.1 Jun 15, 2018
@sphuber sphuber deleted the fix_1632_remove_heavy_test_data_files branch June 15, 2018 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants