Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: fix pgtest failure #1726

Merged
merged 4 commits into from
Jul 10, 2018
Merged

Conversation

dev-zero
Copy link
Contributor

@dev-zero dev-zero commented Jul 6, 2018

Based on travis-ci/travis-ci#9011 it seems we
have to specify explicitly the dependency on the postgresql-dev package
by now.

@dev-zero dev-zero changed the title travis: explicitly install postgresql-server-dev-9.5 travis: fix pgtest failure Jul 6, 2018
@dev-zero
Copy link
Contributor Author

dev-zero commented Jul 6, 2018

ok, now pgtest is unable to start the postgresql server in time (timeout), and the timeout in pgtest is hardcoded to 5s

@DropD
Copy link
Contributor

DropD commented Jul 6, 2018

5 s should be ample time for postgres to start, there might be something preventing the server from starting.

Based on travis-ci/travis-ci#9011 it seems we
have to specify explicitly the dependency on the postgresql-dev package
by now.
@dev-zero dev-zero force-pushed the bugfix/travis-pgtest branch from 35a2294 to 1ea1d4f Compare July 9, 2018 07:50
@codecov-io
Copy link

codecov-io commented Jul 9, 2018

Codecov Report

Merging #1726 into develop will increase coverage by 0.77%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1726      +/-   ##
===========================================
+ Coverage    56.39%   57.16%   +0.77%     
===========================================
  Files          275      275              
  Lines        33912    33912              
===========================================
+ Hits         19123    19386     +263     
+ Misses       14789    14526     -263
Impacted Files Coverage Δ
aiida/backends/djsite/db/models.py 75.97% <0%> (+0.88%) ⬆️
aiida/orm/implementation/django/computer.py 80.85% <0%> (+1.59%) ⬆️
aiida/cmdline/verdilib.py 70.58% <0%> (+2.1%) ⬆️
aiida/control/postgres.py 90.9% <0%> (+2.59%) ⬆️
aiida/common/additions/config_migrations/_utils.py 97.22% <0%> (+2.77%) ⬆️
.../common/additions/config_migrations/_migrations.py 100% <0%> (+3.44%) ⬆️
aiida/backends/djsite/globalsettings.py 86.84% <0%> (+5.26%) ⬆️
aiida/cmdline/commands/user.py 75.64% <0%> (+6.41%) ⬆️
aiida/backends/sqlalchemy/__init__.py 100% <0%> (+14.28%) ⬆️
aiida/common/setup.py 69.18% <0%> (+24.94%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ad95ef...030e716. Read the comment docs.

@dev-zero
Copy link
Contributor Author

dev-zero commented Jul 9, 2018

a debug build in travis shows the following entries when running pgtest's locate command to find the pg_ctl command:

$ locate -r '/pg_ctl$'
/usr/lib/postgresql/9.2/bin/pg_ctl
/usr/lib/postgresql/9.3/bin/pg_ctl
/usr/lib/postgresql/9.4/bin/pg_ctl
/usr/lib/postgresql/9.5/bin/pg_ctl
/usr/lib/postgresql/9.6/bin/pg_ctl

@DropD
Copy link
Contributor

DropD commented Jul 9, 2018

@dev-zero keep in mind if you rebased on develop after friday 6 pm, the relevant tests will be skipped, If you want to know whether this actually fixes the problem, you will have to unskip them.

@dev-zero dev-zero force-pushed the bugfix/travis-pgtest branch from 1ea1d4f to f778d27 Compare July 9, 2018 11:26
@dev-zero dev-zero force-pushed the bugfix/travis-pgtest branch from f778d27 to 030e716 Compare July 9, 2018 12:20
@dev-zero
Copy link
Contributor Author

dev-zero commented Jul 9, 2018

@DropD thanks, I noticed. Can you review the changes? It seems that the issue was that locate inside pgtest was actually picking up PostgreSQL-9.2. Commit 030e716 solves an unrelated issue I encountered when setting up a private Travis instance to get into the debug mode. There a SSH-Key was already available, but with its public key only in authorized_keys instead of a separate id_rsa.pub file. Not sure whether it was because of the debug mode, the private instance or a caching issue.

Copy link
Contributor

@DropD DropD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping out with this!

@DropD
Copy link
Contributor

DropD commented Jul 10, 2018

@dev-zero can you please make a pull request with the same changes to release_v0.12.2?

@DropD DropD merged commit 2132342 into aiidateam:develop Jul 10, 2018
@dev-zero
Copy link
Contributor Author

@DropD np, sure, see PR #1736

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants