-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
travis: fix pgtest failure #1726
Conversation
ok, now |
5 s should be ample time for postgres to start, there might be something preventing the server from starting. |
Based on travis-ci/travis-ci#9011 it seems we have to specify explicitly the dependency on the postgresql-dev package by now.
35a2294
to
1ea1d4f
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1726 +/- ##
===========================================
+ Coverage 56.39% 57.16% +0.77%
===========================================
Files 275 275
Lines 33912 33912
===========================================
+ Hits 19123 19386 +263
+ Misses 14789 14526 -263
Continue to review full report at Codecov.
|
a debug build in travis shows the following entries when running pgtest's locate command to find the
|
@dev-zero keep in mind if you rebased on develop after friday 6 pm, the relevant tests will be skipped, If you want to know whether this actually fixes the problem, you will have to unskip them. |
…iidateam#1724)" This reverts commit 777c16c and fixes aiidateam#1723
1ea1d4f
to
f778d27
Compare
f778d27
to
030e716
Compare
@DropD thanks, I noticed. Can you review the changes? It seems that the issue was that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for helping out with this!
@dev-zero can you please make a pull request with the same changes to |
Based on travis-ci/travis-ci#9011 it seems we
have to specify explicitly the dependency on the postgresql-dev package
by now.