Fix flake8 errors and warnings for python3 #2094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muhrin
approved these changes
Oct 23, 2018
|
Coverage decreased (-7.8%) to 60.073% when pulling a2c2c22604b758bc0bbb4e162cbe8e3266864499 on sphuber:fix_2031_flake_python3 into a4eee1c on aiidateam:develop. |
sphuber
force-pushed
the
fix_2031_flake_python3
branch
2 times, most recently
from
2845ed1 to
e09deaf
Compare
The command that was run is the following: flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics All the warnings and errors have been resolved except for the usage of `long` in the `aiida.backend.tests.nodes` file. This is already properly guarded by `six.PY2` but flake8 clearly does not interpret this clause. We opt to ignore this as the error is not applicable and we do not explicitly include these flake tests in the pre-commit tests.
sphuber
force-pushed
the
fix_2031_flake_python3
branch
from
e09deaf to
2b11224
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2031
The command that was run is the following:
All the warnings and errors have been resolved except for the usage of
longinthe
aiida.backend.tests.nodesfile. This is already properly guarded bysix.PY2but flake8 clearly does not interpret this clause. We opt to ignore this as the
error is not applicable and we do not explicitly include these flake tests in the
pre-commit tests.