Drop the nodeversion and public columns of DbNode
#2937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage decreased (-3.4%) to 69.312% when pulling 5aaae84be9dead35d155bfe6aa9b751cbf297950 on sphuber:fix_2925_drop_node_version_public into fbfabe8 on aiidateam:develop. |
| # self.node.delete_extra(extra_name) | ||
|
|
||
| # with self.assertRaises(AttributeError): | ||
| # self.node.get_extra(extra_name) |
There was a problem hiding this comment.
Are these commented out by mistake?
sphuber
force-pushed
the
fix_2925_drop_node_version_public
branch
from
5aaae84 to
8140933
Compare
These columns have been there from the initial model definition but have not been used at all. The adaptation of the import export format will be taken care of in another commit, that takes all the changes since v0.3 into account in one go.
sphuber
force-pushed
the
fix_2925_drop_node_version_public
branch
from
8140933 to
a7a624e
Compare
This was referenced May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2925
These columns have been there from the initial model definition but have
not been used at all. The adaptation of the import export format will be
taken care of in another commit, that takes all the changes since v0.3
into account in one go.