Correct decorator implementation using the wrapt
library
#2991
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2446
The naive implementation of a decorator will break some of the
functionality of the functions they wrap. For example, the original
docstring will be lost. The module
functools
provides thewraps
decorator to fix this problem, but this is not the only issue. In
addition to the docstring, other properties, such as the function
signature are also lost. This means that using the
inspect
module ondecorated functions is hopelessly broken. The
wrapt
library providesthe
decorator
decorator that simplifies writing decorators, whileensuring that all the important properties of wrapped function are
maintained.