Make construction of AttributeDict recursive
#3005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphuber
force-pushed
the
fix_2996_make_attribute_dict_recursive
branch
from
8a7fa86 to
232531d
Compare
giovannipizzi
approved these changes
Jun 14, 2019
This means that dictionaries nested in the dictionaries will also
recursively be turned into `AttributeDicts`. This has the benefit that
when constructing a nested dictionary like:
dictionary = AttributeDict({'sub': {'name': 1}})
the nested keys can all be accessed as attributes, i.e.:
dictionary.sub.name
whereas before one had to do:
dictionary.sub['name']
which is not very intuitive.
sphuber
force-pushed
the
fix_2996_make_attribute_dict_recursive
branch
from
232531d to
f6bed23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2996
This means that dictionaries nested in the dictionaries will also
recursively be turned into
AttributeDicts. This has the benefit thatwhen constructing a nested dictionary like:
the nested keys can all be accessed as attributes, i.e.:
whereas before one had to do:
which is not very intuitive.