Remove unused QB methods/functions #3526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lekah What about |
I will create a new issue for them. They contain(ed) functionality that was often discussed as important, namely to do graph traversals using the querybuilder, as in node.qb.input().outputs() -> get all outputs of all inputs of a certain node. It looks like some of this functionality was removed, but not the functions within the QueryBuilder... |
lekah
previously approved these changes
Nov 11, 2019
|
Ok for me as soon as @ltalirz approves |
ltalirz
suggested changes
Nov 11, 2019
ltalirz
reviewed
Nov 11, 2019
ltalirz
reviewed
Nov 11, 2019
ltalirz
reviewed
Nov 11, 2019
ltalirz
approved these changes
Nov 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3518.
Also deals with the method mentioned in #3522.
Feel free to find and remove more QueryBuilder code that is completely unused in the code base of AiiDA, if you believe it should not be updated and used.
(Please post here if you want/need writing permissions to my fork).