Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix factories for python>=3.7 #3552

Merged
merged 3 commits into from
Nov 15, 2019
Merged

fix factories for python>=3.7 #3552

merged 3 commits into from
Nov 15, 2019

Conversation

yakutovicha
Copy link
Contributor

fixes #3551

@yakutovicha yakutovicha requested a review from sphuber November 15, 2019 15:19
@yakutovicha
Copy link
Contributor Author

This part of the code is already in the tests, so I didn't add more

aiida-core/aiida/backends/tests/plugins/test_factories.py

Line 90 in 33bd8b1

plugin = factories.CalculationFactory('calc_function')

aiida-core/aiida/backends/tests/plugins/test_factories.py

Line 106 in 33bd8b1

plugin = factories.WorkflowFactory('work_function')

greschd
greschd previously approved these changes Nov 15, 2019
View reviewed changes
aiida/plugins/factories.py Outdated Show resolved Hide resolved
sphuber
sphuber approved these changes Nov 15, 2019
View reviewed changes
Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yakutovicha

@sphuber sphuber merged commit 1de41ca into aiidateam:develop Nov 15, 2019
@yakutovicha yakutovicha deleted the fix_3551_factories branch January 6, 2020 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sphuber sphuber sphuber approved these changes

@greschd greschd greschd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(process) Factories do not work with python 3.7
3 participants
@yakutovicha @greschd @sphuber