Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config migration: handle edge case #3585

Merged
merged 1 commit into from
Nov 27, 2019
Merged

config migration: handle edge case #3585

merged 1 commit into from
Nov 27, 2019

Conversation

ltalirz
Copy link
Member

@ltalirz ltalirz commented Nov 27, 2019 •
edited
Loading

fix #3583

handle edge case in config file migration if 'daemon' key is missing in
'default_profiles'

@ltalirz
config migration: handle edge case
df2e068 
handle edge case in config file migration if 'daemon' key is missing in
'default_profiles'
@ltalirz ltalirz requested a review from sphuber November 27, 2019 17:29
sphuber
sphuber approved these changes Nov 27, 2019
View reviewed changes
Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ltalirz

@sphuber sphuber merged commit 5aa0fff into aiidateam:develop Nov 27, 2019
@sphuber sphuber deleted the issue_3583_config_migration branch November 27, 2019 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sphuber sphuber sphuber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in config migration?
2 participants
@ltalirz @sphuber