Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use built-in 'open' instead of 'io.open'. #3615

Merged
merged 1 commit into from
Dec 9, 2019

Conversation

greschd
Copy link
Member

@greschd greschd commented Dec 9, 2019

The io.open was previously used for py2/py3 compatibility. In Python3, io.open is simply an alias for the open built-in, so there is no reason not to use the more standard open instead.

The 'io.open' was previously used for py2/py3 compatibility. In
Python3, 'io.open' is simply an alias for the 'open' built-in, so
there is no reason not to use the more standard 'open' instead.
@sphuber sphuber self-requested a review December 9, 2019 10:42
Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love me some code cleanup, thanks @greschd

@sphuber sphuber merged commit cc49ee9 into aiidateam:develop Dec 9, 2019
@greschd greschd deleted the remove_io_open branch December 13, 2019 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants