Make sure that datetime conversions ignore None
#3628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The functions `datetime_to_isoformat` and `isoformat_to_datetime` assumed to always have a proper type (string or datetime) as input. However, in some cases, they were called with values that could be potentially `None`, like this in aiida/engine/utils.py: ``` timezone.isoformat_to_datetime(manager.get(key).value)) ``` We are now directly returning `None` if `None` is passed as an input (and then it's up to the caller to then decide what to do with the value. Fixes aiidateam#3336
|
Possibly related test failure? https://github.com/aiidateam/aiida-core/pull/3637/checks?check_run_id=342693485 EDIT: same problem, different code part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functions
datetime_to_isoformatandisoformat_to_datetimeassumed to always have a proper type (string or datetime) as input.
However, in some cases, they were called with values that could
be potentially
None, like this in aiida/engine/utils.py:We are now directly returning
NoneifNoneis passed as aninput (and then it's up to the caller to then decide what to do
with the value.
Fixes #3336