Add support for python 3.8 #3719
Conversation
This behavior will raise starting from python 3.8.
This behaviour is no longer supported in python 3.8:
python/cpython@3715176557cf
For an enum `SomeEnum`, one can no longer do:
if 'SOME_VALUE' not in SomeEnum:
raise ValueError()
but instead one should use `isinstance` directly. After all an enum
is simply a normal python class.
sphuber
force-pushed
the
fix_3662_python_3_8
branch
from
c0d14f1 to
b985838
Compare
Cheered to early! Tests on my branch run, but on the PR they fail in one of the file system tests. There seems to be a problem with |
sphuber
force-pushed
the
fix_3662_python_3_8
branch
from
b985838 to
0cc3dce
Compare
The test was calling `insert_path` from a filepath into itself. When moving to python 3.8 this was triggering a weird recursive condition in the underlying `shutil.copytree` call that kept concatenating the `šaltinis/destination` sub string to the target filepath. This would eventually throw an error that the filepath was too long. The origin for this occurring all of a sudden in python 3.8 is unsure, but most likely the recursive copy in the test was a typo and not intended.
Run CI tests on python 3.8 instead of 3.7.
sphuber
force-pushed
the
fix_3662_python_3_8
branch
from
0cc3dce to
741e976
Compare
|
@dev-zero and @ltalirz thanks for the review. As you may have noticed, the tests on my branch ran, but on the pull request failed. Specifically it was a single test testing the |
|
@sphuber I think that's fine since the test is about unicode handling of path names rather than the logic of |
Fixes #3662
Note, I have not checked the compatibility of all our (sub)dependencies manually, but the tests run.