Convert argument to str in aiida.common.escaping.escape_for_bash
#3873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without conversion to string, any non-string type will cause the function to raise an `AttributeError` since it won't have the method `str_replace`.
sphuber
force-pushed
the
fix/3872/escape-for-bash
branch
from
76c23d2 to
0517b9a
Compare
Codecov Report
@@ Coverage Diff @@
## develop #3873 +/- ##
========================================
Coverage 77.15% 77.16%
========================================
Files 458 458
Lines 33788 33789 +1
========================================
+ Hits 26070 26072 +2
+ Misses 7718 7717 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3872
Without conversion to string, any non-string type will cause the
function to raise an
AttributeErrorsince it won't have the methodstr_replace.Supersedes #3769