Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python intersphinx mapping #3876

Merged
merged 1 commit into from
Mar 29, 2020

Conversation

ltalirz
Copy link
Member

@ltalirz ltalirz commented Mar 28, 2020

Add intersphinx mapping to python standard library documentation, i.e.
things like :py:exc:ValueError now link directly there.
This also allows to cut down the "nitpick exceptions" quite
dramatically.

Note: I will rebase this PR after #3875 is merged

@codecov
Copy link

codecov bot commented Mar 28, 2020

Codecov Report

Merging #3876 into develop will not change coverage by %.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3876   +/-   ##
========================================
  Coverage    77.18%   77.18%           
========================================
  Files          457      457           
  Lines        33779    33779           
========================================
  Hits         26072    26072           
  Misses        7707     7707           
Flag Coverage Δ
#django 69.22% <50.00%> (ø)
#sqlalchemy 70.04% <50.00%> (ø)
Impacted Files Coverage Δ
aiida/cmdline/params/options/interactive.py 83.47% <ø> (ø)
aiida/engine/processes/calcjobs/tasks.py 32.36% <ø> (ø)
aiida/orm/implementation/logs.py 100.00% <ø> (ø)
aiida/orm/logs.py 95.00% <ø> (ø)
aiida/orm/nodes/data/array/xy.py 16.17% <0.00%> (ø)
aiida/engine/processes/process_spec.py 93.47% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d12a424...4f24698. Read the comment docs.

@sphuber
Copy link
Contributor

sphuber commented Mar 28, 2020

This is great @ltalirz , thanks. I think it would maybe also be good to add plumpy and kiwipy or is there something preventing us from doing that?

@ltalirz
Copy link
Member Author

ltalirz commented Mar 28, 2020

I think it would maybe also be good to add plumpy and kiwipy or is there something preventing us from doing that?

Right - there was no docs for plumpy on RTD (fixed it just now), and the one from kiwipy was not linked from the readme (opened PRs).
I'll have a go at adding them now as well.

Add intersphinx mapping to python standard library documentation and of
various direct dependency libraries:

 * `click`
 * `flask`
 * `flask_restful`
 * `kiwipy`
 * `plumpy`

Adding this documentation interconnection allows references in our docs
like :py:exc:`ValueError` to now directly link to the relevant external
documentation. This also allows to cut down the "nitpick exceptions"
quite dramatically.
@sphuber sphuber force-pushed the add-python-intersphinx branch from 2073327 to 4f24698 Compare March 29, 2020 20:31
@sphuber sphuber self-requested a review March 29, 2020 20:43
Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ltalirz . I added a few more fixes and details

@sphuber sphuber merged commit 58bace3 into aiidateam:develop Mar 29, 2020
@sphuber sphuber deleted the add-python-intersphinx branch March 29, 2020 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants