Drop support for Python 3.5 #4386
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4386 +/- ##
===========================================
- Coverage 79.22% 79.22% -0.00%
===========================================
Files 475 475
Lines 34826 34822 -4
===========================================
- Hits 27588 27583 -5
- Misses 7238 7239 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
sphuber
force-pushed
the
fix/4367/drop-python-3.5
branch
from
cfb4a3b to
9d54d60
Compare
utils/dependency_management.py
Outdated
| @@ -30,7 +30,7 @@ | |||
| 'graphviz': 'python-graphviz', | |||
| } | |||
|
|
|||
| CONDA_IGNORE = ['pyblake2', r'.*python_version == \"3\.5\"'] | |||
| CONDA_IGNORE = ['pyblake2'] | |||
There was a problem hiding this comment.
didn't you remove pyblake2 from the dependency list?
i.e. can't this list be empty?
There was a problem hiding this comment.
I guess, it is a backport from hashlib.blake2b which become part of stdlib from Python 3.6. So this would then also apply to conda, wouldn't it? Do you want me to also remove the CONDA_IGNORE variable and associated code, or we just leave it as an empty list.
There was a problem hiding this comment.
Do you want me to also remove the CONDA_IGNORE variable and associated code, or we just leave it as an empty list.
Up to you - it's difficult for me to guess how likely it is that we will need such exceptions again. Maybe more likely than not.
If you decide to leave it in for the moment, perhaps add a comment explaining what it does and setting an ultimatum in 6? months after which it can be removed
There was a problem hiding this comment.
@csadorf I think this is your code. What do you prefer? I leave it in for now?
There was a problem hiding this comment.
I'd prefer to leave it in.
Python 3.5 is EOL as of September 13 2020. CI testing will now only be done against Python 3.6 and 3.8.
sphuber
force-pushed
the
fix/4367/drop-python-3.5
branch
from
9d54d60 to
78157f2
Compare
Fixes #4367
Python 3.5 is EOL as of September 13 2020. CI testing will now only be
done against Python 3.6 and 3.8.