Fix aiida.cmdline.utils.decorators.with_dbenv always loading the db
#4865
Conversation
The premise of the method `with_dbenv` is that it will load the profile and corresponding database environment if not already loaded. However, due to a bug in `load_backend_if_not_loaded` it was actually *always* loading the environment for every call, even if the database env was already loaded, leading to very expensive calls for nothing.
Codecov Report
@@ Coverage Diff @@
## develop #4865 +/- ##
===========================================
- Coverage 79.62% 79.62% -0.00%
===========================================
Files 519 519
Lines 37109 37110 +1
===========================================
- Hits 29546 29544 -2
- Misses 7563 7566 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@ramirezfranciscof also this would be good to quickly merge and release with 1.6.2 |
|
@sphuber is there a way to add a quick test that uses this method twice and somehow checks that there was not a double load? It would be nice to have, but I do recognize that it is not clear to me how it could check for that... |
It could be done: we would have to mock the database loading env by a function that counts the number of times it is called with a global and raises the second time. But I didn't have the time to implement it and don't think it was necessary for this change. Doubt that this will accidentally be reverted at some point. |
|
Ok, I'll just open an issue then and we can just merge it as is (maybe if its quick and we don't have other problems I can even take care of it during the coding days after merging the new repository). |
Fixes #4864
The premise of the method
with_dbenvis that it will load the profileand corresponding database environment if not already loaded. However,
due to a bug in
load_backend_if_not_loadedit was actually alwaysloading the environment for every call, even if the database env was
already loaded, leading to very expensive calls for nothing.