-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BaseRestartWorkChain: deal with namespaced outputs #4961
BaseRestartWorkChain: deal with namespaced outputs #4961
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## develop #4961 +/- ##
===========================================
+ Coverage 80.12% 80.17% +0.05%
===========================================
Files 515 515
Lines 36745 36746 +1
===========================================
+ Hits 29438 29457 +19
+ Misses 7307 7289 -18
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
e3245d3
to
050ecf1
Compare
@unkcpz hey do you know what the problem is with the pre-commits? Once that is settled I think this should be good to merge. |
050ecf1
to
6bc67ee
Compare
@ramirezfranciscof thanks! It is now ready to be merged I hope. |
6bc67ee
to
10e2c28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good now, thanks! Do you have merging privileges or do you need me to merge it? (in which case also let me know what description you want to leave in the commit message)
`BaseRestartWorkChain` does not return `output_namespaces` of `_process_class` as describe in aiidateam#4623. It happend because in the `results` method of `BaseRestartWorkChain`, only output keys go through by `node.get_outgoing` are checked and returned by the parent WorkChain. The exposed_outputs adapt to output the whole nested namespace by `exposed_outputs`. The `out_many` method is not used here to make a post-check for ports to remain the original exit code check and report.
10e2c28
to
2c380a1
Compare
Thanks @ramirezfranciscof, I don't have the merging privileges, could you authorize me to do it (and direct me to where I can find the workflow to merge and things need to take care of)? As for this PR, please merge it for me and I updated the commit message. Correct it if you find any typos, must have some, I am not good at writing (you don't know what a writer I am in Chinese 🤣). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Silly me last time I left a comment instead of approving.
I think this may be because I forgot to approve and instead just left a comment. Do you want to check again? If you still can't make it then I'll just merge it myself and then look into how to enable this for you.
Haha, no worries, I am also not an English native speaker and I have my difficulties with the language as well =P. I adapted it a bit, could you check that the information is still correct and I didn't misinterpret anything?
|
@ramirezfranciscof I still can't merge. The commit message looks great, thanks for merging it! |
The `BaseRestartWorkChain` did not return an `output_namespace` of its `_process_class` as described in #4623. It happened because in its `results` method, only the output keys are obtained from the call to `node.get_outgoing` (checked and returned by the parent WorkChain). This was changed for a call to `exposed_outputs`, which instead returns the whole nested namespace. The `out_many` method is not used here in order to make a post-check for ports that allows to keep the original exit code check and report. Cherry-pick: e1abe0a
Fixes #4623
To also output the namespace of
BaseRestartWorkChain
. Instead of usingout_many
to dump all outputs from inner process, here I compare the outputs of sub process with the required port. The details are mentioned in #4623.