Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DirectScheduler: use num_cores_per_mpiproc if defined in resources #5126

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented Sep 9, 2021

If num_cores_per_mpiproc is specified in the job resources, the value
will now be exported as the OMP_NUM_THREADS variable.

Supersedes #5051

If `num_cores_per_mpiproc` is specified in the job resources, the value
will now be exported as the `OMP_NUM_THREADS` variable.

Co-Authored-By: Sebastiaan Huber <mail@sphuber.net>
@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #5126 (37a9d23) into develop (d33ae8a) will increase coverage by 0.02%.
The diff coverage is 87.50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5126      +/-   ##
===========================================
+ Coverage    80.82%   80.83%   +0.02%     
===========================================
  Files          534      534              
  Lines        36946    36951       +5     
===========================================
+ Hits         29857    29865       +8     
+ Misses        7089     7086       -3     
Flag Coverage Δ
django 75.65% <87.50%> (+0.02%) ⬆️
sqlalchemy 74.73% <87.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiida/schedulers/plugins/direct.py 66.28% <87.50%> (+3.41%) ⬆️
aiida/transports/plugins/local.py 81.41% <0.00%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d33ae8a...37a9d23. Read the comment docs.

@sphuber
Copy link
Contributor Author

sphuber commented Sep 9, 2021

Merging this myself without approval. It was already approved by @giovannipizzi in #5051

@sphuber sphuber merged commit 37a9d23 into aiidateam:develop Sep 9, 2021
@sphuber sphuber deleted the feature/recognize-cores_per_mpiproc-direct-sched branch September 9, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants