-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Python 3.10 #5188
Support Python 3.10 #5188
Conversation
Manual checks:
|
c34222d
to
6d9b318
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5188 +/- ##
===========================================
- Coverage 81.30% 81.30% -0.00%
===========================================
Files 529 529
Lines 37031 37031
===========================================
- Hits 30105 30104 -1
- Misses 6926 6927 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Status update:
|
Status update:
|
13d9f0e
to
5532a8e
Compare
The issues with the conda environment are now reported here: s-weigand/setup-conda#169 |
5532a8e
to
87c9f8f
Compare
Blocked by #5231 . |
44af547
to
5717aeb
Compare
This looks to be ready to go now, right @csadorf ? One question I had is whether we should change the |
Yes, this is almost ready. There is an issue with circus that we should probably wait on to be resolved before merging this.
If I remember correctly, I don't think we forgot, the issue was that the pip installation was possible with 3.9, but still took significantly longer, because some dependencies needed to be compiled since no wheels where available. We might face the same issue here, but I am going to look into updating it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updates
…ings. Since version "numbers" are not actually numbers, which can lead to bugs, e.g., when a version number like "3.10" is interpreted as a decimal or float and is thus equal to 3.1.
Co-authored-by: Chris Sewell <chrisj_sewell@hotmail.com>
ee16bbe
to
bd6bbc8
Compare
Please update the requirements/ files to ensure that they |
Co-authored-by: csadorf <csadorf@users.noreply.github.com>
@chrisjsewell Should be ready to merge, I enabled auto-merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @csadorf
@csadorf Just mentioning that I'm getting
This is on my macbook M1 + also on @chrisjsewell 's x86 macbook. It's not quite clear to my why... perhaps there is no wheel uploaded for macos? We'll open an issue on spglib |
Opened spglib/spglib#143 I'll open a PR on aiida-core to downgrade spglib |
Indeed, likely an architecture issue. Looks like we might have to start testing on different architectures to catch this... 🙄 Thanks for the PR! |
Closes #5146 .