Add validate_table_existence to abstract SettingsManager
#5236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #5236 +/- ##
===========================================
+ Coverage 81.38% 81.39% +0.01%
===========================================
Files 529 529
Lines 37008 37009 +1
===========================================
+ Hits 30116 30118 +2
+ Misses 6892 6891 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
The `BackendManager` was using the `validate_table_existence` from its `SettingsManager` member, but this method was not defined in the abstract class. It was present in both backends implementations, but there would be nothing requiring from the abstract parent class. This is mostly a "formal" quickfix.
ramirezfranciscof
force-pushed
the
abstract_missing
branch
from
e1bfed2 to
b5b67fc
Compare
giovannipizzi
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
BackendManagerwas using thevalidate_table_existencefrom itsSettingsManagermember, but this method was not defined in the abstractclass. It was present in both backends implementations, but there would
be nothing requiring from the abstract parent class.
This is mostly a "formal" quickfix.