Add missing migration of transport entry points in archives

[janssenhenning]

Fixes #5587

[sphuber]

Thanks a lot for the contribution @janssenhenning . This would be an important fix to add indeed. The fix itself looks good, however, we can't be putting this in the existing migration and should really rather create a new one. The reason is that since the 11 -> 12 migration has already been released, there will be archives out there with v12 that does not contain the migration. To have these migrate as well, we need to create a new 12 -> 13 migration. Could you add this separately? You can just copy paste from existing migrations and tests

[janssenhenning]

@sphuber Sorry for the late response. I now moved it into a separate migration

[sphuber]

Thanks a lot @janssenhenning that looks good. Could you just add a test for it please? If you don't have the time, let me know and I can see if I can add it, no problem.

[janssenhenning]

@sphuber There is a test that the migration works. The test in tools/archive/migration/test_legacy_funcs.py is parametrized with all of the migrations in the dictionary LEGACY_MIGRATE_FUNCTIONS in aiida.storage.sqlite_zip.migrations.legacy

I didin't see an explicit test for the 0.11 to 0.12 migration to check if the entry points are correctly changed beyond the test I mentioned. If I missed it could you point me to the file, where this test is located? I can add this of course if you want.

[sphuber]

@sphuber There is a test that the migration works. The test in tools/archive/migration/test_legacy_funcs.py is parametrized with all of the migrations in the dictionary LEGACY_MIGRATE_FUNCTIONS in aiida.storage.sqlite_zip.migrations.legacy

That parametrized test just checks that the migration does not except and the generic migration actions, such as updating the version in the metadata, is done correctly. There is no explicit check on the actual migration specific functionality.

I didin't see an explicit test for the 0.11 to 0.12 migration to check if the entry points are correctly changed beyond the test I mentioned. If I missed it could you point me to the file, where this test is located? I can add this of course if you want.

You are right, there isn't one for 0.11 to 0.12. There are a few more missing for recent migrations, but they are there uptil 0.9. They are in the directory tools/archive/migration/. Would be good to add test_v012_to_v013.py there.

[janssenhenning]

Would be good to add test_v012_to_v013.py there.

Done

[sphuber]

Thanks a lot @janssenhenning !