BaseRestartWorkChain: Fix bug in _wrap_bare_dict_inputs
#5757
Conversation
Codecov ReportBase: 79.87% // Head: 79.87% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## release/2.1.2 #5757 +/- ##
=================================================
+ Coverage 79.87% 79.87% +0.01%
=================================================
Files 496 496
Lines 37027 37028 +1
=================================================
+ Hits 29573 29574 +1
Misses 7454 7454
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
In ae79c89, released with `v2.1.0`, the `InputPort` class was updated to automatically add `None` as a valid type to the `valid_type` tuple if the port is not required. This unintentionally broke the `BaseRestartWorkChain._wrap_bare_dict_inputs` method which is supposed to wrap bare dictionaries in the inputs if the corresponding port accepts a `Dict` node. However, it was checking that the `valid_type` was equal to `Dict` instead of checking that the tuple contains the `Dict` type. As a results, bare dictionaries were no longer automatically wrapped in `Dict` node after the change mentioned above. Here the logic is updated to check whether the `Dict` type is in the `valid_type` tuple.
sphuber
force-pushed
the
fix/base-restart-workchain
branch
from
e1c5bdf to
46dbb86
Compare
There was a problem hiding this comment.
Code looks good, and I tested it in the field and all seems to work fine.
In principle the change that caused this bug is not fully backwards-compatible, but perhaps it's ok. Not sure how many other plugins use code that relies on checking the valid_type of an input port that is not required. 🤷
Since the change is quite useful, I am tempted to just keep it and fix the bug in the |
In ae79c89, released with
v2.1.0, theInputPortclass was updated to automatically addNoneas a valid type to thevalid_typetuple if the port is not required. This unintentionally broke theBaseRestartWorkChain._wrap_bare_dict_inputsmethod which is supposed to wrap bare dictionaries in the inputs if the corresponding port accepts aDictnode. However, it was checking that thevalid_typewas equal toDictinstead of checking that the tuple contains theDicttype. As a results, bare dictionaries were no longer automatically wrapped inDictnode after the change mentioned above.Here the logic is updated to check whether the
Dicttype is in thevalid_typetuple.