👌 IMPROVE: Add dataclass serialisation to context #5833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphuber
reviewed
Dec 13, 2022
| @@ -136,6 +158,8 @@ def represent_data(self, data): | |||
| return represent_computer(self, data) | |||
| if isinstance(data, orm.Group): | |||
| return represent_group(self, data) | |||
| if is_dataclass(data) and not inspect.isclass(data): | |||
There was a problem hiding this comment.
Just out of interest, why is the second clause necessary? What is an example of an object passing is_dataclass(obj) and inspect.isclass(obj)?
There was a problem hiding this comment.
In [15]: import inspect
In [16]: from dataclasses import asdict, dataclass, is_dataclass
In [17]: @dataclass
...: class DataClass:
...: """A dataclass for testing."""
...: my_value: int
...:
In [18]: is_dataclass(DataClass) and inspect.isclass(DataClass)
Out[18]: True
In [19]: asdict(DataClass)
---------------------------------------------------------------------------
TypeError Traceback (most recent call last)
<ipython-input-19-c90f518d2aad> in <module>
----> 1 asdict(DataClass)
~/Documents/GitHub/aiida_core_develop/.tox/py38-pre-commit/lib/python3.8/dataclasses.py in asdict(obj, dict_factory)
1070 """
1071 if not _is_dataclass_instance(obj):
-> 1072 raise TypeError("asdict() should be called on dataclass instances")
1073 return _asdict_inner(obj, dict_factory)
1074
TypeError: asdict() should be called on dataclass instancesThere was a problem hiding this comment.
for some reason, _is_dataclass_instance is private 🤷
Co-authored-by: Sebastiaan Huber <mail@sphuber.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.