Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update custom data plugin documentation #5898

Merged
merged 3 commits into from
Feb 22, 2023
Merged

Conversation

zhubonan
Copy link
Contributor

Warn the user that the constructor is not called when the node is loaded from the database at a later time.

This may not be immediately clear that the constructor will not be called (and it cannot be called) when loaded a Data from the database.

Warn the user that the constructor is not called when the node is loaded from the database at a later time.
@zhubonan
Copy link
Contributor Author

I just used the Edit button on the GitHub page, somehow GitHub created a new branch on the main repo no on my fork...

Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zhubonan . Saw the discussion on Slack, agree that this should be clarified. Have a suggestion on the wording.

docs/source/topics/data_types.rst Outdated Show resolved Hide resolved
Co-authored-by: Sebastiaan Huber <mail@sphuber.net>
@zhubonan
Copy link
Contributor Author

Thanks I agree, the updated version is clearer 😊

@sphuber sphuber merged commit 34f7dee into main Feb 22, 2023
@sphuber sphuber deleted the custom-data-class-docs-update branch February 22, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants