Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Add alternative for conda env activation in submission script #5950

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Docs: Add alternative for conda env activation in submission script #5950

merged 1 commit into from
Mar 30, 2023

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented Mar 30, 2023 •
edited
Loading

Fixes #5895

@sphuber sphuber requested review from chrisjsewell and ltalirz March 30, 2023 10:53
ltalirz
ltalirz reviewed Mar 30, 2023
View reviewed changes
docs/source/howto/run_codes.rst Outdated
This can be achieved by configuring the ``shebang`` property of the ``Computer`` to ``#!/bin/bash -l``.
This ensures that the submission script uses a login shell which initializes conda properly.

If for some reason your submission script cannot use a login script, the following ``prepend_text`` can be used instead:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If for some reason your submission script cannot use a login script, the following ``prepend_text`` can be used instead:
If the submission script should not use a login shell (e.g. because that sources other dotfiles that are unnecessary), the following ``prepend_text`` can be used instead:

@sphuber sphuber force-pushed the fix/5895/docs-conda-login-shell branch from 3c70cc7 to 49a993d Compare March 30, 2023 13:27
@sphuber
Copy link
Contributor Author

sphuber commented Mar 30, 2023

@chrisjsewell you also happy with these changes?

chrisjsewell
chrisjsewell approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep great cheers

@sphuber sphuber merged commit 728f266 into aiidateam:main Mar 30, 2023
@sphuber sphuber deleted the fix/5895/docs-conda-login-shell branch March 30, 2023 16:21
@sphuber sphuber mentioned this pull request Mar 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisjsewell chrisjsewell chrisjsewell approved these changes

@ltalirz ltalirz ltalirz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should the use_login_shell property of the AuthInfo also be considered in the submission script shebang
3 participants
@sphuber @ltalirz @chrisjsewell