CLI: Add --timeout option to all verdi daemon commands
#5966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The timeout is passed on to the `DaemonClient` and can be used to override the default that is defined through the `daemon.timeout` config option. This can be useful, for example, when the default timeout set in the configuration is low such that commands don't get stuck unnecessarily long. However, for certain commands, such as `verdi daemon stop`, it might make sense to give the client a bit more time to respond.
sphuber
force-pushed
the
feature/5637/cli-daemon-timeout
branch
from
244567d to
dbdb808
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5637
The timeout is passed on to the
DaemonClientand can be used to override the default that is defined through thedaemon.timeoutconfig option. This can be useful, for example, when the default timeout set in the configuration is low such that commands don't get stuck unnecessarily long. However, for certain commands, such asverdi daemon stop, it might make sense to give the client a bit more time to respond.