Add 'verdi workflow kill' command #779
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphuber
reviewed
Oct 19, 2017
| if not self.is_sealed: | ||
| self._set_attr(self.ABORTED_KEY, True) | ||
| self.seal() |
There was a problem hiding this comment.
the self.seal() should be within the conditional block
sphuber
reviewed
Oct 19, 2017
| self._set_attr(self.ABORTED_KEY, True) | ||
| self.seal() | ||
| for key, child in self.get_outputs_dict().items(): |
There was a problem hiding this comment.
You can pass the desired link type to get_outputs_dict(link_type=LinkType.CALL) which is safer than relying on the label
|
@sphuber I implemented your suggestions, thanks! |
|
I have taken your commits and created a new branch to add some necessary fixes. I created a new PR #821 so I am closing this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
_abortflag to the WorkCalculation, which is checked before each step. The calculations are also sealed which usually causes them to fail pretty immediately, but also means that thereportwill not contain a nice abort message.The
killis propagated to all children through the CALL links.Fixes #661 and #741 for the "old" system, but not 0.11.