Improve verdi work list and verdi work report #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, the current WorkCalculation nodes do not have a well defined canonical method of checking their 'state' as for example is the case with JobCalculations. What it does have are several attribute keys, FAILED, SEALED and FINISHED that can be set. However, there is no guarantee for example that if neither FAILED nor FINISHED are not set, that the calculation is still 'running'. As a temporary convention we only disply calculations who are set to be SEALED. The -a/--all-states flag, analogous to the verdi calculation list command, can be toggled to display all work calculations.
The verdi work report command retrieves the log messages attached to a work calculation node and all the call descendents. For each level of descendent, the ouput is indented when printed. The new flag allows to limit the maximum depth to traverse down the descendents chain.
Recently another terminal state was added for WorkCalculations to be able to support aborting running WorkCalculations. With that the state picture of a WorkCalculation also became a little bit better defined. A WorkCalculation has three terminal states: * FINISHED * FAILED * ABORTED These states are set by the corresponding attribute to the node and are mutually exclusive. If the WorkCalculation is in neither one of these three terminal states, it can be considered by inference to be RUNNING. A node can also be sealed or unsealed. It can only be sealed until after it has reached one of the three terminal states. If a node is sealed but is not in a terminal state, the state is inconsistent and so we print Unknown. This is to prevent from WorkCalculations during which the code excepted will be incorrectly labeled as RUNNING, which would confuse the user.
giovannipizzi
approved these changes
Nov 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #318
Improvements to
verdi work listandverdi work reportRecently another terminal state was added for
WorkCalculationstobe able to support aborting running
WorkCalculations. With thatthe state picture of a
WorkCalculationalso became a little bitbetter defined. A
WorkCalculationhas three terminal states:FINISHEDFAILEDABORTEDThese states are set by the corresponding attribute to the node
and are mutually exclusive. If the
WorkCalculationis in neitherone of these three terminal states, it can be considered by
inference to be
RUNNING.A node can also be sealed or unsealed. It can only be sealed until
after it has reached one of the three terminal states. If a node
is sealed but is not in a terminal state, the state is inconsistent
and so we print
Unknown. This is to prevent fromWorkCalculationsduring which the code excepted will be incorrectly labeled
as
RUNNING, which would confuse the user.