Only return a retrieved_temporary_folder FolderData if non-empty #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no files were specified in the 'retrieve_temporary_list' of the calculations CalcInfo, we should not pass an empty FolderData to the parse_from_calc call of the Parser. Otherwise the parse_with_retrieved call will always get a retrieved_temporary_folder, even if it is empty. By setting retrieved_temporary_folder to None, unless some files have been specified in the retrieve_temporary_list member we maintain the original behavior of the execmanager calling the parser
sphuber
force-pushed
the
fix_886_retrieve_temporary_list
branch
from
556b40a to
88d29e6
Compare
giovannipizzi
approved these changes
Nov 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick bug fix for the already closed issue #886
If no files were specified in the 'retrieve_temporary_list' of the
calculations CalcInfo, we should not pass an empty FolderData to
the parse_from_calc call of the Parser. Otherwise the parse_with_retrieved
call will always get a retrieved_temporary_folder, even if it is
empty. By setting retrieved_temporary_folder to None, unless some
files have been specified in the retrieve_temporary_list member
we maintain the original behavior of the execmanager calling the
parser