✨ NEW: Transformer for removing dict and list keywords #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbercx
added
the
pr/blocked
|
Ready for review! |
mbercx
removed
the
pr/blocked
mbercx
force-pushed
the
new/dict-list-keywords
branch
3 times, most recently
from
df5b293 to
f8be454
Compare
We recently adapted the constructors of the `Dict` and `List` nodes so they no longer require the `dict` and `list` keywords, see: aiidateam/aiida-core#5165 Here we add a transformer that automatically removes these keywords from `Dict` and `List` constructors if present.
mbercx
force-pushed
the
new/dict-list-keywords
branch
from
f8be454 to
a0923a2
Compare
sphuber
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently adapted the constructors of the
DictandListnodes sothey no longer require the
dictandlistkeywords, see:aiidateam/aiida-core#5165
Here we add a transformer that automatically removes these keywords from
DictandListconstructors if present.