Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hexagone Package logo #112

Merged
merged 7 commits into from
Jul 25, 2024
Merged

Add hexagone Package logo #112

merged 7 commits into from
Jul 25, 2024

Conversation

BatoolMM
Copy link
Member

@BatoolMM BatoolMM commented Jul 24, 2024 •
edited
Loading

Closes #

Proposed Changes

Checklist before review:

  • Please review README
  • Please comment on my PR while it's a draft and give me feedback on the development!
  • I added everything I wanted to add to this PR, please review!
  • The title of this PR is clear and self-explantory.
  • I added any appropriate labels to this PR.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 24, 2024
@BatoolMM BatoolMM added the enhancement Feature improvement or addition label Jul 24, 2024
@RayStick RayStick self-requested a review July 25, 2024 07:58
RayStick
RayStick reviewed Jul 25, 2024
View reviewed changes
Copy link
Member

@RayStick RayStick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this Batool!
Looks great
Except that the README formatting seems to have got mixed up from 'Using your own input files' ownwards
Will take a look later :)

@BatoolMM
Copy link
Member Author

Yes, true - thank you for reviewing it very carefully - I noticed that README got changes.

@RayStick
Copy link
Member

Hmm I can see you updated to main (fed18aa) but it did not seem to have the updated changes from the README, weird.

I think I have correct it all now

@RayStick RayStick merged commit 16a15e5 into main Jul 25, 2024
2 checks passed
@RayStick RayStick deleted the package-logo branch July 25, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RayStick RayStick RayStick approved these changes

Assignees

@BatoolMM BatoolMM

Labels
documentation Improvements or additions to documentation enhancement Feature improvement or addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a logo for the package
2 participants
@BatoolMM @RayStick