Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme has been updated. #133

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Readme has been updated. #133

wants to merge 3 commits into from

Conversation

Atharva-77
Copy link

Separate column of 'Sr.No.' has been created instead of 'Chapter' column only.
Thanks @Nalinc for assiging me this issue.Looking forward for more such open source contributions.
Happy Coding :-)

Separate column of 'Sr.No.'  has been created from 'Chapter' column.
Separate column of Sr.No.(Serial Number) has been created instead of 'Chapter' column only.
Thanks @Nalinc for assigning me this issue.
Happy Coding and looking forward for more such open source contributions. :-)
@sachin10101998
Copy link
Contributor

@Atharva2018 you need to work on your commits. Your pull request has 3 commits with names as follows:

  1. Readme has been updated.
  2. Merge Pull request ...
  3. Readme has been updated.
    Ideally it should contain only one commit. Existence of two different commits under the same name makes no sense. It gets tougher to understand if someone goes through commits and sees these messages.
    Little investigation tells that you made another commit just to add another column in chapter 27 which should have been done alongside the commit #3078182. Make sure your commits are concise and precise before you submit a pull request.

@Atharva-77
Copy link
Author

@sachin10101998 Thanks for your advise. Will keep that in mind from next time. Do I need to again make a PR with single commit ?

@sachin10101998
Copy link
Contributor

@Atharva2018 If it's not too much to ask for, you should. @Nalinc has to make the final call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants