Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current State of NextJS with Issues #33

Closed
16 of 18 tasks
camposcristian opened this issue Nov 20, 2019 · 4 comments
Closed
16 of 18 tasks

Current State of NextJS with Issues #33

camposcristian opened this issue Nov 20, 2019 · 4 comments

Comments

@camposcristian
Copy link
Contributor

camposcristian commented Nov 20, 2019

Styling issues / issues with pages that will be re-designed

@kbardi I'm breaking these out separately because some might be faster for @lulen11 to lead the work on because she could make interim design/content changes v matching what is on production px for px.

  • Global Nav centred instead of right aligned
  • About page text issue
  • Font/line-hight is off on a number of pages. i.e. here and here
  • Update the homepage to match production or chat with @charliemckenzie / @mischacolley re new content
  • UI on /positions broken. Big white space missing vide etc // Match production with potential to update vid message and image to something fresher?
  • Form UI broken on Be a Mentor. // Fixing this should help get out mind in gear re what this needs to say in terms of Global Pilot and 2020 Aus program
  • Nav styles not correct // As long as not broken this is a low priority as @charliemckenzie might quickly have refreshed design for us

Assets/Content issues

  • Be a Mentor missing banner image
  • About page missing image assets
  • Add favicon
@mischacolley
Copy link
Contributor

@kbardi Are there any outstanding items on this that aren't in other issues already? Can we close?

@lulen11
Copy link
Contributor

lulen11 commented Jan 8, 2020

@kbardi do you have any updates on this one?

@kbardi
Copy link
Contributor

kbardi commented Jan 9, 2020

@mischacolley @lulen11

  1. About the PhoneInput, I have to talk with @davidpaley so maybe we can review the component tomorrow to make it work also on portal, and we can start using it on website.
  2. I'm not sure what is the error here:

// Fixing this should help get out mind in gear re what this needs to say in terms of Global Pilot and 2020 Aus program
But I fixed some errors there, and I think Lara also fixed some things there, so maybe it can be checked...what is the error in here? Right now it looks like
image
image

@mischacolley
Copy link
Contributor

@kbardi all good. I'm closing this as you are already dealing with the phone input and the other stuff with this form is a none issue as #66 will replace it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants