Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gimbal to replace lighthousebot #28

Closed
wants to merge 1 commit into from

Conversation

bronz3beard
Copy link
Contributor

resolves #4

  • Budget for Lighthouse (5 s / bundle size / etc)

This is to replace lighthouse-bot as the end point is no longer being maintained (see issue).
Rather than setup our own endpoint to host puppeteer or headless chrome, we will try gimbal

Known issue with gimbal (Minor for what we need to use it for)
issue
PR

To run gimbal locally you can use the following script: yarn run gimbal-audit

gimbal config is found in the .gimbalrc.yml this is currently setup top only show tests that fail.
It will display results in the terminal and you can also find the reports in ./gimbal-artifacts

The next step is to setup comments on a PR with github actions:
gimbal-gh-action checkout the workflow file. I believe the aim is to set this up using the github aime-bot?

@bronz3beard bronz3beard temporarily deployed to website-v5-feature-perf-tmcqlf October 29, 2019 05:32 Inactive
Copy link
Contributor

@kbardi kbardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, but testing it locally it exists with 1, and it means it throws an error...
error Command failed with exit code 1.
Not sure which is the error, of if it's related to some params we added to pass lighthouse correctly

@kbardi I have submitted an issue (link above) requesting why the gimbal audit doesn't use the config file unless I explicitly tell gimbal where to find the file, see the command script in package.json, Modus informed me it is a bug, which could also be causing the exit code of 1.

As for the .gimbalrc.yml this config was taken from there docs with some minor changes, modus reviewed my pr (link above) then replicated the issue and tagged it as a bug, so you could be right regarding what is being past to each test, if you have a minute feel free to play around with it.
I will continue to make adjustments to the config and see what happens, but I have also seen the error 1, without the use of a config file. so I am waiting to hear back from modus, they have been active in responding to me so I have hope for an answer soon 😄

Thanks for the review Kevin

@bronz3beard
Copy link
Contributor Author

Current output on github Gimbal performance report

@camposcristian camposcristian removed their request for review November 18, 2019 04:30
@camposcristian
Copy link
Contributor

@kbardi once you merge #31 could you speak with Rory so we can transfer this work to the new architecture?

kbardi added a commit that referenced this pull request Nov 20, 2019
@kbardi
Copy link
Contributor

kbardi commented Nov 22, 2019

I close it because I merged it on the new architecture (branch feature/donate-with-nextjs)

@kbardi kbardi closed this Nov 22, 2019
@kbardi kbardi deleted the feature/performance-monitoring-gimbal branch March 9, 2020 20:06
camposcristian pushed a commit that referenced this pull request Jul 17, 2020
camposcristian pushed a commit that referenced this pull request Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants