Printer-friendly enhancements, web-rendering should stay the same #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added a sectionBlock class and set it to use display: flex instead of inline-block. Inline-block was interfering with page-breaks, so when the experience section was long it wasn't wrapping. * Created a div with class jobBlock to wrap each separate job, added css to prevent the browser from page-breaking within these blocks. * Set the browser to print anchors as black text instead of purple and blue
ainsleyc
added a commit
that referenced
this pull request
Sep 8, 2015
Printer-friendly enhancements, web-rendering should stay the same
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know this is a "onepage" theme, but there's no reason it can't look good wrapping to a new page. :)
sectionBlockclass and set it to usedisplay: flexinstead ofinline-block.inline-blockwas interfering with page-breaks, so when the experience section was long it wasn't wrapping.jobBlockto wrap each separate job, added css to prevent the browser from page-breaking within these blocks.