Crash with aiohttp 3.1.x related to use of StreamReader #551

adamrothman · 2018-03-22T21:57:22Z

I'm getting a crash using aiobotocore 0.6.0 with aiohttp 3.1.0 (released yesterday 2018-03-21). It appears to be related to botocore's response checking:

Traceback (most recent call last):
  File "test.py", line 20, in <module>
    loop.run_until_complete(main())
  File "/usr/local/Cellar/python/3.6.4_4/Frameworks/Python.framework/Versions/3.6/lib/python3.6/asyncio/base_events.py", line 467, in run_until_complete
    return future.result()
  File "test.py", line 12, in main
    response = await client.describe_table(TableName='orbit-prod-identities')
  File "/Users/adam/Desktop/aiobotocore-test/venv/lib/python3.6/site-packages/aiobotocore/client.py", line 94, in _make_api_call
    operation_model, request_dict)
  File "/Users/adam/Desktop/aiobotocore-test/venv/lib/python3.6/site-packages/aiobotocore/endpoint.py", line 290, in _send_request
    exception)):
  File "/Users/adam/Desktop/aiobotocore-test/venv/lib/python3.6/site-packages/aiobotocore/endpoint.py", line 322, in _needs_retry
    caught_exception=caught_exception, request_dict=request_dict)
  File "/Users/adam/Desktop/aiobotocore-test/venv/lib/python3.6/site-packages/botocore/hooks.py", line 227, in emit
    return self._emit(event_name, kwargs)
  File "/Users/adam/Desktop/aiobotocore-test/venv/lib/python3.6/site-packages/botocore/hooks.py", line 210, in _emit
    response = handler(**kwargs)
  File "/Users/adam/Desktop/aiobotocore-test/venv/lib/python3.6/site-packages/botocore/retryhandler.py", line 183, in __call__
    if self._checker(attempts, response, caught_exception):
  File "/Users/adam/Desktop/aiobotocore-test/venv/lib/python3.6/site-packages/botocore/retryhandler.py", line 251, in __call__
    caught_exception)
  File "/Users/adam/Desktop/aiobotocore-test/venv/lib/python3.6/site-packages/botocore/retryhandler.py", line 269, in _should_retry
    return self._checker(attempt_number, response, caught_exception)
  File "/Users/adam/Desktop/aiobotocore-test/venv/lib/python3.6/site-packages/botocore/retryhandler.py", line 317, in __call__
    caught_exception)
  File "/Users/adam/Desktop/aiobotocore-test/venv/lib/python3.6/site-packages/botocore/retryhandler.py", line 220, in __call__
    return self._check_response(attempt_number, response)
  File "/Users/adam/Desktop/aiobotocore-test/venv/lib/python3.6/site-packages/botocore/retryhandler.py", line 335, in _check_response
    actual_crc32 = crc32(response[0].content) & 0xffffffff
TypeError: a bytes-like object is required, not 'StreamReader'

Here's a minimal reproducer:

# -*- coding: utf-8 -*-
import asyncio
from pprint import pprint

import aiobotocore


async def main():
    session = aiobotocore.get_session()
    client = session.create_client('dynamodb')

    response = await client.list_tables()
    pprint(response)

    await client.close()


if __name__ == '__main__':
    loop = asyncio.get_event_loop()
    loop.run_until_complete(main())

I've also tried client.describe_table, which results in the same error. It seems like the semantics for StreamReader have changed such that it can no longer be treated like data.

The crash does not occur with aiohttp 3.0.9.

Environment:

Python 3.6.4
aiobotocore 0.6.0
aiohttp 3.1.0
botocore 1.8.21

The text was updated successfully, but these errors were encountered:

thehesiod · 2018-03-22T22:00:07Z

ya, we should have caught in #536 that aiohttp needs to be upper-bound version locked. We need to add a comment so people don't do this again.

asvetlov · 2018-03-23T14:26:34Z

Sorry, guys. My personal fault.
Support for sending StreamReader was dropped. I wanted to replace it with support for any async iterator by aio-libs/aiohttp/issues/2802

But I did run too fast.
Now I think the lost functionality is a critical bug, it will be fixed by pushing async iterator feature into next 3.1 bugfix release (coming soon).

Sorry again.
@thehesiod could you postpone the locking aiohttp upper version?

As alternative I see the commitment on publishing a new aiobotocore version with the lock raised up to the latest aiohttp after every aiohttp release if tests are passed. It looks too complex burden.

On my side I wish to use the latest aiobotocore with the latest aiohttp (my company uses both libraries).
I know about aiobotocore pain related to timeouts but I see a big progress on aio-libs/aiohttp/issues/2768
The first PR aio-libs/aiohttp/pull/2842 is not perfect from my perspective but personally I've got a vision how user interface would look like.
I'm expecting to land new timeouts on aiohttp 3.2 1-2 months from now.

thehesiod · 2018-03-23T16:00:53Z

@asvetlov no worries! will do

adamrothman · 2018-03-23T22:36:49Z

Thanks guys, libraries these and maintainers like you are why I love Python. 🤗

asvetlov · 2018-03-28T02:26:39Z

Fixed by aiohttp 3.1.1 release

adamrothman · 2018-03-28T19:36:46Z

@asvetlov I'm still getting the same crash after updating to aiohttp 3.1.1:

Traceback (most recent call last):
  File "test.py", line 21, in <module>
    loop.run_until_complete(main())
  File "/usr/local/Cellar/python/3.6.4_4/Frameworks/Python.framework/Versions/3.6/lib/python3.6/asyncio/base_events.py", line 467, in run_until_complete
    return future.result()
  File "test.py", line 13, in main
    response = await client.list_tables()
  File "/Users/adam/Desktop/aiobotocore-test/venv/lib/python3.6/site-packages/aiobotocore/client.py", line 94, in _make_api_call
    operation_model, request_dict)
  File "/Users/adam/Desktop/aiobotocore-test/venv/lib/python3.6/site-packages/aiobotocore/endpoint.py", line 290, in _send_request
    exception)):
  File "/Users/adam/Desktop/aiobotocore-test/venv/lib/python3.6/site-packages/aiobotocore/endpoint.py", line 322, in _needs_retry
    caught_exception=caught_exception, request_dict=request_dict)
  File "/Users/adam/Desktop/aiobotocore-test/venv/lib/python3.6/site-packages/botocore/hooks.py", line 227, in emit
    return self._emit(event_name, kwargs)
  File "/Users/adam/Desktop/aiobotocore-test/venv/lib/python3.6/site-packages/botocore/hooks.py", line 210, in _emit
    response = handler(**kwargs)
  File "/Users/adam/Desktop/aiobotocore-test/venv/lib/python3.6/site-packages/botocore/retryhandler.py", line 183, in __call__
    if self._checker(attempts, response, caught_exception):
  File "/Users/adam/Desktop/aiobotocore-test/venv/lib/python3.6/site-packages/botocore/retryhandler.py", line 251, in __call__
    caught_exception)
  File "/Users/adam/Desktop/aiobotocore-test/venv/lib/python3.6/site-packages/botocore/retryhandler.py", line 269, in _should_retry
    return self._checker(attempt_number, response, caught_exception)
  File "/Users/adam/Desktop/aiobotocore-test/venv/lib/python3.6/site-packages/botocore/retryhandler.py", line 317, in __call__
    caught_exception)
  File "/Users/adam/Desktop/aiobotocore-test/venv/lib/python3.6/site-packages/botocore/retryhandler.py", line 220, in __call__
    return self._check_response(attempt_number, response)
  File "/Users/adam/Desktop/aiobotocore-test/venv/lib/python3.6/site-packages/botocore/retryhandler.py", line 335, in _check_response
    actual_crc32 = crc32(response[0].content) & 0xffffffff
TypeError: a bytes-like object is required, not 'StreamReader'

thehesiod · 2018-03-29T02:19:53Z

ya, seems like ClientResponse.content is StreamReader and not string/bytes anymore

asvetlov · 2018-03-29T02:47:03Z

But ClientResponse.content was a StreamReader from time of birth.
3.3.1 restored a broken/removed functionality for passing a content as a body: await client.post(url, data=resp.content), nothing more.

thehesiod · 2018-04-28T06:09:49Z

@asvetlov @adamrothman figured it out, looks like ClientResponse._content was renamed to ClientResponse._body. Fix will be in: #564

thehesiod · 2018-05-01T08:12:59Z

fixed with #569

nitrocode · 2018-05-01T15:50:15Z

Thank you for fixing this issue. I just tripped over it on the 0.6.0 version. I tried upgrading and it looks like 0.6.1 has not been published to pypi. Do you mind publishing it @thehesiod ?

jettify · 2018-05-01T16:01:12Z

Probably due to typo 0.6.1a0 was published https://pypi.org/project/aiobotocore/0.6.1a0/

thehesiod · 2018-05-01T16:07:37Z

very weird, I don't remember putting a0

jettify · 2018-05-01T16:11:01Z

https://pypi.org/project/aiobotocore/0.7.0/ released new version

jettify · 2018-05-01T16:18:28Z

sigh, this time RST formatting is broken on PyPI

thehesiod · 2018-05-01T16:19:26Z

weird, how did that happen?

jettify · 2018-05-01T16:24:52Z

I edited changes.rst and broke formatting #571 , anyway added command to test RST correctness.

French-Noodles · 2020-12-25T15:35:14Z

So is there any fix for this now? im kinda confused on how to do it

async def requestingresponse():
  async with aiohttp.ClientSession() as cs:
    async with cs.get(url) as res:
      response = res
      bytes = BytesIO(response._body)
      img = Image.open(bytes)
      img.show()  

asyncio.run(requestingresponse())

this is my code but now im getting this error after i changed .content to ._body

PIL.UnidentifiedImageError: cannot identify image file <_io.BytesIO object at 0x00000272F288E6D0>

thehesiod · 2020-12-29T18:37:56Z

you can't directly pass response['Body'] to BytesIO as it's an async stream

thehesiod mentioned this issue Mar 24, 2018

get_credentials() fails on AioSession #553

Closed

asvetlov closed this as completed Mar 28, 2018

adamrothman changed the title ~~Crash with aiohttp 3.1.0 related to use of StreamReader~~ Crash with aiohttp 3.1.x related to use of StreamReader Mar 28, 2018

asvetlov reopened this Mar 29, 2018

thehesiod closed this as completed May 1, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Crash with aiohttp 3.1.x related to use of StreamReader #551

Crash with aiohttp 3.1.x related to use of StreamReader #551

adamrothman commented Mar 22, 2018

thehesiod commented Mar 22, 2018 •

edited

Loading

asvetlov commented Mar 23, 2018

thehesiod commented Mar 23, 2018

adamrothman commented Mar 23, 2018

asvetlov commented Mar 28, 2018

adamrothman commented Mar 28, 2018

thehesiod commented Mar 29, 2018

asvetlov commented Mar 29, 2018

thehesiod commented Apr 28, 2018

thehesiod commented May 1, 2018

nitrocode commented May 1, 2018

jettify commented May 1, 2018

thehesiod commented May 1, 2018

jettify commented May 1, 2018

jettify commented May 1, 2018

thehesiod commented May 1, 2018

jettify commented May 1, 2018

French-Noodles commented Dec 25, 2020

thehesiod commented Dec 29, 2020

Crash with aiohttp 3.1.x related to use of StreamReader #551

Crash with aiohttp 3.1.x related to use of StreamReader #551

Comments

adamrothman commented Mar 22, 2018

thehesiod commented Mar 22, 2018 • edited Loading

asvetlov commented Mar 23, 2018

thehesiod commented Mar 23, 2018

adamrothman commented Mar 23, 2018

asvetlov commented Mar 28, 2018

adamrothman commented Mar 28, 2018

thehesiod commented Mar 29, 2018

asvetlov commented Mar 29, 2018

thehesiod commented Apr 28, 2018

thehesiod commented May 1, 2018

nitrocode commented May 1, 2018

jettify commented May 1, 2018

thehesiod commented May 1, 2018

jettify commented May 1, 2018

jettify commented May 1, 2018

thehesiod commented May 1, 2018

jettify commented May 1, 2018

French-Noodles commented Dec 25, 2020

thehesiod commented Dec 29, 2020

thehesiod commented Mar 22, 2018 •

edited

Loading