Adopt aiohttp>=3.0.0 (#519) #536
Conversation
Gr1N
force-pushed
the
519-adopt-aiohttp3
branch
from
e8a6308
to
9ac8990
Compare
Codecov Report
@@ Coverage Diff @@
## master #536 +/- ##
==========================================
+ Coverage 90.05% 90.07% +0.01%
==========================================
Files 8 8
Lines 523 524 +1
==========================================
+ Hits 471 472 +1
Misses 52 52
Continue to review full report at Codecov.
|
setup.py
Outdated
| 'multidict>=2.1.4', | ||
| 'wrapt>=1.10.10', | ||
| 'packaging>=16.8', | ||
| ] | ||
|
|
||
| PY_VER = sys.version_info | ||
|
|
||
| if not PY_VER >= (3, 4, 1): | ||
| raise RuntimeError("aiobotocore doesn't support Python earlier than 3.4") | ||
| if not PY_VER >= (3, 5, 0): |
There was a problem hiding this comment.
3.5.3 actually. The same in all other places
Gr1N
force-pushed
the
519-adopt-aiohttp3
branch
from
9ac8990
to
e7e0c6e
Compare
tests/test_patches.py
Outdated
|
|
||
| # for our patch of _wait | ||
| StreamReader: {'c0a9a31a8c3e550de5985ab642028983f709b37b'}, | ||
| StreamReader: {'d4ffb6ae823ef4bfd810aade8601ba7b01aa08ec'}, | ||
|
|
||
| # for digging into _protocol ( 2.1.x, 2.2.x ) |
There was a problem hiding this comment.
can remove 2.1.x, 2.2.x
|
cool looks good! I validated the changes to aiobotocore and looks like there's no impact to us, yay. just have one comment to remove a comment :) Let's see what @jettify says too. |
|
would be good to bump to the latest botocore too, but we can do that in another PR |
Gr1N
force-pushed
the
519-adopt-aiohttp3
branch
from
e7e0c6e
to
008a313
Compare
| # `self._loop` explicitly because from `aiohttp>=3.0.0` we can't | ||
| # pass `loop` as a kwargs into `run_app`. | ||
| with mock.patch('asyncio.get_event_loop', return_value=self._loop): | ||
| aiohttp.web.run_app(app, host=host, port=self._port, |
There was a problem hiding this comment.
We can use new AppRunner stuff as result we do not need ugly patch
https://docs.aiohttp.org/en/stable/web_advanced.html?highlight=AppRunner#application-runners
|
Changes looks good to me as well, one nitpick. We can merge PR as it is and handle runner stuff in separate PR |
|
@jettify maybe it's bad, but I don't want to spend time on |
|
thanks! |
Dropped support of Python 3.4 and aiohttp < 3.0.0.