Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.12 and drop EOL 3.7 #1034

Merged
merged 4 commits into from
Aug 17, 2023
Merged

Add support for Python 3.12 and drop EOL 3.7 #1034

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0461022
Drop support for EOL Python 3.7
hugovk Aug 16, 2023
57cb84b
Add support for Python 3.12
hugovk Aug 16, 2023
8baf1bb
Add to changelog
hugovk Aug 17, 2023
2497d3c
Update version and add an arbitrary date
hugovk Aug 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .github/workflows/python-package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,21 @@ on:
- 'master'
- '[0-9].[0-9]+.[0-9]+'

env:
FORCE_COLOR: 1

jobs:
test:
name: Test Python ${{ matrix.python-version }}
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ['3.8', '3.9', '3.10', '3.11']
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12']
include:
- aiohttp-version: '==3.7.4.post0'
- aiohttp-version: '<4.0.0'
python-version: '3.11'
fail-fast: true
fail-fast: false
timeout-minutes: 15
steps:
- name: Checkout
Expand All @@ -32,6 +35,7 @@ jobs:
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}
allow-prereleases: true
- name: Lock and sync dependencies
env:
AIOHTTP_VERSION: ${{ matrix.aiohttp-version }}
Expand All @@ -51,7 +55,7 @@ jobs:
make mototest
- name: Upload coverage to Codecov
if: matrix.python-version == '3.11'
uses: codecov/codecov-action@v3.1.1
uses: codecov/codecov-action@v3.1.4
with:
token: ${{ secrets.CODECOV_TOKEN }} # not required for public repos
files: ./coverage.xml
Expand Down
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ repos:
hooks:
- id: pyupgrade
args:
- '--py37-plus'
- '--py38-plus'
- repo: 'https://github.com/psf/black'
rev: 22.8.0
hooks:
Expand Down
1 change: 1 addition & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
Changes
-------

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a new line for the next release with this, should probably bump to 2.7.0 since we're removing 3.7 support

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! I didn't know what date to put, so used today as an arbitrary date.

2.6.0 (2023-08-11)
^^^^^^^^^^^^^^^^^^
* bump aiohttp minimum version to 3.7.4.post0
Expand Down
2 changes: 1 addition & 1 deletion README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ https://groups.google.com/forum/#!forum/aio-libs

Requirements
------------
* Python_ 3.7+
* Python_ 3.8+
* aiohttp_
* botocore_

Expand Down
3 changes: 2 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ def read_version():
'Programming Language :: Python :: 3.9',
'Programming Language :: Python :: 3.10',
'Programming Language :: Python :: 3.11',
'Programming Language :: Python :: 3.12',
'Environment :: Web Environment',
'Framework :: AsyncIO',
],
Expand All @@ -62,7 +63,7 @@ def read_version():
download_url='https://pypi.python.org/pypi/aiobotocore',
license='Apache License 2.0',
packages=find_packages(include=['aiobotocore']),
python_requires='>=3.7',
python_requires='>=3.8',
install_requires=install_requires,
extras_require=extras_require,
include_package_data=True,
Expand Down
6 changes: 0 additions & 6 deletions tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
import os
import random
import string
import sys
import tempfile
from contextlib import ExitStack
from itertools import chain
Expand All @@ -22,11 +21,6 @@
_PYCHARM_HOSTED = os.environ.get('PYCHARM_HOSTED') == '1'


def pytest_cmdline_preparse(args):
if sys.version_info[:2] < (3, 8):
args[:] = ["--ignore", 'tests/python3.8'] + args


@pytest.fixture(
scope="session", params=[True, False], ids=['debug[true]', 'debug[false]']
)
Expand Down