Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support up-to-date botocore #1048

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Conversation

jakob-keller
Copy link
Collaborator

@jakob-keller jakob-keller commented Oct 21, 2023

Description of Change

This PR intends to improve general compatibility of aiobotocore within the Python ecosystem by relaxing the dependency specification of botocore, as well as boto3 and awscli.

Assumptions

Upstream diff does not contain any changes that require adjustments to the aiobotocore codebase. This allows for the proposed widening of the botocore dependency specification.

Checklist for All Submissions

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

@jakob-keller
Copy link
Collaborator Author

I intend to monitor botocore releases and regularly push updates until it is worth merging this PR.

@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f67503a) 86.39% compared to head (7d996f4) 86.39%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1048   +/-   ##
=======================================
  Coverage   86.39%   86.39%           
=======================================
  Files          60       60           
  Lines        5807     5807           
=======================================
  Hits         5017     5017           
  Misses        790      790           
Flag Coverage Δ
unittests 86.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CHANGES.rst Outdated Show resolved Hide resolved
@thehesiod
Copy link
Collaborator

ok let me know when you want to merge

@thehesiod
Copy link
Collaborator

want to convert to draft meanwhile?

@jakob-keller jakob-keller marked this pull request as draft October 23, 2023 17:10
@jakob-keller jakob-keller marked this pull request as ready for review October 25, 2023 22:15
@jakob-keller
Copy link
Collaborator Author

I suggest we merge now and extend support to include botocore==1.31.70.

botocore==1.31.71 might be a little bit more involved due to boto/botocore#3037.

@thehesiod thehesiod merged commit 281e68d into aio-libs:master Nov 16, 2023
7 checks passed
@jakob-keller jakob-keller deleted the botocore-update branch November 16, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants