Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align dev dependencies and linting with upstream #1049

Merged
merged 10 commits into from
Oct 24, 2023

Conversation

jakob-keller
Copy link
Collaborator

@jakob-keller jakob-keller commented Oct 21, 2023

Description of Change

Dev dependencies and linting deviate significantly between botocore (upstream) and aiobotocore. This PR works towards alignment by:

  • leveraging pre-commit to orchestrate linting and bump hooks
  • dropping dev dependencies covered by pre-commit
  • bumping remaining dev dependencies
  • including setuptools as dev dependency for Python >=3.12
  • leveraging pyproject.toml to configure pytest
  • leveraging setup.cfg to configure flake8

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #1049 (e84b536) into master (718e40b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1049   +/-   ##
=======================================
  Coverage   86.38%   86.39%           
=======================================
  Files          60       60           
  Lines        5803     5805    +2     
=======================================
+ Hits         5013     5015    +2     
  Misses        790      790           
Flag Coverage Δ
unittests 86.39% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
aiobotocore/credentials.py 88.62% <ø> (ø)
aiobotocore/session.py 78.84% <100.00%> (ø)
tests/boto_tests/test_credentials.py 98.22% <ø> (ø)
tests/python3.8/boto_tests/test_signers.py 100.00% <ø> (ø)
tests/test_config.py 100.00% <ø> (ø)
tests/test_patches.py 95.91% <ø> (ø)
tests/test_session.py 100.00% <ø> (ø)
tests/test_version.py 95.37% <100.00%> (+0.08%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jakob-keller jakob-keller marked this pull request as ready for review October 23, 2023 17:56
requirements-dev.in Outdated Show resolved Hide resolved
@jakob-keller jakob-keller changed the title Bump dev dependencies Align dev dependencies and checks with upstream Oct 23, 2023
@jakob-keller jakob-keller changed the title Align dev dependencies and checks with upstream Align dev dependencies and linting with upstream Oct 23, 2023
@thehesiod
Copy link
Collaborator

wow, u da man

@thehesiod thehesiod merged commit 60613c0 into aio-libs:master Oct 24, 2023
11 checks passed
@jakob-keller jakob-keller deleted the dev-dependencies branch October 24, 2023 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants