Fix race condition in S3 Express identity cache #1073
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
A race condition in the S3 Express identity cache was introduced in 110b0a2. This change modifies the cache to hold
asyncio.Task
instances instead of actual credentials to mitigate the issue without introducing locking.Assumptions
Replace this text with any assumptions made (if any)
Checklist for All Submissions
asyncio.Task
instances that wrap the underlyingget_credentials
coroutine.Checklist when updating botocore and/or aiohttp versions