Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RTD #1094

Merged
merged 5 commits into from
Feb 28, 2024
Merged

Fix RTD #1094

merged 5 commits into from
Feb 28, 2024

Conversation

astrojuanlu
Copy link
Contributor

Description of Change

Replace this text with why this change is required and how it was accomplished

Assumptions

Replace this text with any assumptions made (if any)

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

@thehesiod thehesiod self-requested a review February 28, 2024 17:32
Copy link
Collaborator

@thehesiod thehesiod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have no idea how this works, but if it passes I'll merge ;)

@astrojuanlu
Copy link
Contributor Author

Almost there :)

@astrojuanlu
Copy link
Contributor Author

Done! https://aiobotocore--1094.org.readthedocs.build/en/1094/

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.23%. Comparing base (a42d00b) to head (188c721).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1094      +/-   ##
==========================================
- Coverage   86.28%   86.23%   -0.06%     
==========================================
  Files          60       60              
  Lines        5870     5870              
==========================================
- Hits         5065     5062       -3     
- Misses        805      808       +3     
Flag Coverage Δ
unittests 86.23% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/conf.py Outdated Show resolved Hide resolved
@thehesiod
Copy link
Collaborator

thank you! just one comment

@thehesiod thehesiod enabled auto-merge (squash) February 28, 2024 17:38
@thehesiod thehesiod merged commit 1a1b2f8 into aio-libs:master Feb 28, 2024
9 checks passed
@astrojuanlu astrojuanlu deleted the patch-1 branch February 28, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants