Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing retries/__init__.py #1129

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Conversation

jakob-keller
Copy link
Collaborator

Description of Change

Turn aiobotocore/retries into a regular python package by adding empty aiobotocore/retries/__init__.py.

Assumptions

aiobotocore/retries should be a regular python package, mirroring botocore/retries.

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

@jakob-keller jakob-keller marked this pull request as ready for review August 2, 2024 12:07
@jakob-keller jakob-keller requested a review from thehesiod August 2, 2024 12:08
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.11%. Comparing base (2bd2c77) to head (d7236bc).
Report is 128 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1129   +/-   ##
=======================================
  Coverage   86.11%   86.11%           
=======================================
  Files          62       62           
  Lines        5933     5933           
=======================================
  Hits         5109     5109           
  Misses        824      824           
Flag Coverage Δ
unittests 86.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakob-keller jakob-keller added the bug Something isn't working label Aug 2, 2024
@thehesiod thehesiod enabled auto-merge (squash) August 6, 2024 21:05
@thehesiod thehesiod merged commit aec730a into aio-libs:master Aug 6, 2024
13 checks passed
@jakob-keller jakob-keller deleted the retries-init branch August 6, 2024 21:19
chemelli74 pushed a commit to chemelli74/aiobotocore that referenced this pull request Aug 29, 2024
Co-authored-by: Alexander Mohr <thehesiod@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants